Skip to content

Only process EmptyModuleOrNamespaces when showHeader is true.#13883

Merged
dsyme merged 3 commits into
dotnet:mainfrom
nojaf:empty-module-signature
Sep 14, 2022
Merged

Only process EmptyModuleOrNamespaces when showHeader is true.#13883
dsyme merged 3 commits into
dotnet:mainfrom
nojaf:empty-module-signature

Conversation

@nojaf

@nojaf nojaf commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

Fixes #13869

image

FSI passes false for showHeader:

let responseL = NicePrint.layoutImpliedSignatureOfModuleOrNamespace false denv infoReader AccessibleFromSomewhere m mexpr

@nojaf nojaf force-pushed the empty-module-signature branch from 9385c89 to 7372474 Compare September 12, 2022 14:44
@nojaf nojaf force-pushed the empty-module-signature branch from eaf8b2c to cca1887 Compare September 13, 2022 10:03
@dsyme

dsyme commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

@vzarytovskii Note this one has to be prioritised for release

@dsyme dsyme enabled auto-merge (squash) September 14, 2022 14:33
@dsyme dsyme merged commit 68e1600 into dotnet:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running FSI prints "module FSI_001" before anything else

2 participants